🐛 Fixed comped subscription duration drop-down sometimes not being visible #15764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible closes TryGhost/Product#2110 - added failing test showing feature service `@feature` properties weren't autotracking correctly if accessed before authentication+settings fetch occurs - shows labs and feature properties on the feature service are not reacting to changes in the settings service - removing the `@computed` on the `feature.labs` getter stops it being cached but it then fails on the `feature.testFlag` computed property - updated `settings` service to behave as expected with our current version of Ember - inspected the store schema for `Setting` to define the "proxied" properties up-front rather than only after fetching - updated the property definition to use `computed` so we're opting in to the old style reactivity (required adding the `@classic` decorator to pass linting)
kevinansfield
added a commit
that referenced
this pull request
Nov 4, 2022
…sible (#15764) closes TryGhost/Product#2110 - added failing test showing feature service `@feature` properties weren't autotracking correctly if accessed before authentication+settings fetch occurs - shows labs and feature properties on the feature service are not reacting to changes in the settings service - removing the `@computed` on the `feature.labs` getter stops it being cached but it then fails on the `feature.testFlag` computed property - updated `settings` service to behave as expected with our current version of Ember - inspected the store schema for `Setting` to define the "proxied" properties up-front rather than only after fetching - updated the property definition to use `computed` so we're opting in to the old style reactivity (required adding the `@classic` decorator to pass linting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/TryGhost/Team/issues/2110
@featureproperties weren't autotracking correctly if accessed before authentication+settings fetch occurs@computedon thefeature.labsgetter stops it being cached but it then fails on thefeature.testFlagcomputed propertysettingsservice to behave as expected with our current version of EmberSettingto define the "proxied" properties up-front rather than only after fetchingcomputedso we're opting in to the old style reactivity (required adding the@classicdecorator to pass linting)