[WIP] TypeScript Spike 🦔 #16713
[WIP] TypeScript Spike 🦔 #16713
Conversation
allouis
force-pushed
the
wip-typescript-spike
branch
from
e0abea5
to
5040adb
Compare
| const log = console.log; | ||
| /* eslint-enable no-console */ | ||
|
|
||
| fs.copyFile('./public/main.css', './umd/main.css', (err) => { |
There was a problem hiding this comment.
This file doesn't exist since 21b621c
I had to update this because it was messing up the ability to run lerna run build from monorepo root
| "build": "tsc --build", | ||
| "prepare": "yarn build", | ||
| "setup": "yarn build", | ||
| "test:unit": "NODE_ENV=testing c8 --src src --all --check-coverage --100 --reporter text --reporter cobertura mocha -r ts-node/register './test/**/*.test.ts'", |
There was a problem hiding this comment.
ts-node means we don't need to add a compile step for tests - I think this is preferable for now
ghost/post-revisions/package.json
Outdated
| "test:unit": "NODE_ENV=testing c8 --all --check-coverage --100 --reporter text --reporter cobertura mocha './test/**/*.test.js'", | ||
| "dev": "tsc --build --watch --preserveWatchOutput", | ||
| "build": "tsc --build", | ||
| "prepare": "yarn build", |
There was a problem hiding this comment.
This means that the project will be built after running yarn
ghost/post-revisions/tsconfig.json
Outdated
| // "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */ | ||
|
|
||
| /* Language and Environment */ | ||
| "target": "es2019", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */ |
There was a problem hiding this comment.
AFAIK This is correct for Node 14
There was a problem hiding this comment.
Given we've dropped Node 14, you can probs bump this now
| @@ -33,7 +33,7 @@ | |||
| "main": "yarn main:monorepo && yarn main:submodules", | |||
| "main:monorepo": "git checkout main && git pull ${GHOST_UPSTREAM:-origin} main && yarn", | |||
| "main:submodules": "git submodule sync && git submodule update && git submodule foreach \"git checkout main && git pull ${GHOST_UPSTREAM:-origin} main && yarn\"", | |||
| "prepare": "husky install .github/hooks" | |||
| "prepare": "husky install .github/hooks && lerna run prepare" | |||
There was a problem hiding this comment.
This works with the post-revision prepare script so that running yarn in the top level will build all necessary packages
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #16713 +/- ##
===========================================
- Coverage 84.70% 72.07% -12.64%
===========================================
Files 692 1787 +1095
Lines 53396 113379 +59983
Branches 6832 16921 +10089
===========================================
+ Hits 45228 81713 +36485
- Misses 8097 30564 +22467
- Partials 71 1102 +1031
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
allouis
force-pushed
the
wip-typescript-spike
branch
6 times, most recently
from
166708f
to
c492fd2
Compare
ghost/core/package.json
Outdated
| @@ -231,11 +231,13 @@ | |||
| "eslint": "8.37.0", | |||
| "expect": "29.3.1", | |||
| "form-data": "4.0.0", | |||
| "ghost-admin": "5.46.0", | |||
There was a problem hiding this comment.
Do you reckon we can use a * here? It's gonna be a pain to keep the version in sync (more code in Ghost-Release) and I'd like to clean up the process that means we need this, but not necessarily now
There was a problem hiding this comment.
Yeah I don't see why not!
ghost/core/package.json
Outdated
| "inquirer": "8.2.5", | ||
| "jwks-rsa": "3.0.1", | ||
| "mocha": "10.2.0", | ||
| "mocha-slow-test-reporter": "0.1.2", | ||
| "mock-knex": "TryGhost/mock-knex#d8b93b1c20d4820323477f2c60db016ab3e73192", | ||
| "monobundle": "allouis/monobundle", |
There was a problem hiding this comment.
I can/will move my original one to TryGhost once we resolve the PR there
allouis
force-pushed
the
wip-typescript-spike
branch
from
1f89891
to
45213aa
Compare
allouis
force-pushed
the
wip-typescript-spike
branch
from
f1ad24a
to
190599c
Compare
- Updates the prepare script in the top level to run prepare on packages, so that packages can be built when running `yarn` - Updates the build script in ghost/core to run build on packages, so that packages are built before being monobundled - Updates monobundle to be a dependency and use the new TryGhost repo, which includes some minor fixes and improvements, such as supporting devDeps - Updates the GitHub workflows to run the build command in the top level directory rather than ghost/core so that other packages are built, too.
This is an initial start to using TypeScript in our non-core Ghost packages. - Adds a prepare script to build the project after installing deps - Adds an initial tsconfig.json which is compatible with our node env - Migrates all of the code to TypeScript, including tests - Updates tests to use ts-node so that we don't need to compile the tests - ts-node is installed at the top level because the env is weird with lerna and doesn't work otherwise - Updates the yarn dev script to build the project with the --all and --revisions flag
allouis
force-pushed
the
wip-typescript-spike
branch
from
190599c
to
8adc500
Compare
🍦
🤖 Generated by Copilot at c605838
This pull request refactors the
post-revisionspackage from JavaScript to TypeScript, improving the code quality and type safety. It also updates the imports of thePostRevisionsclass in thecorepackage and thedevscript in the.githubfolder. Additionally, it removes some redundant code from thesodo-searchpackage.