Extracted model event interceptor to separate package #17151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #17151 +/- ##
==========================================
+ Coverage 71.64% 71.75% +0.10%
==========================================
Files 1833 1836 +3
Lines 116270 116456 +186
Branches 17259 17289 +30
==========================================
+ Hits 83307 83568 +261
+ Misses 31845 31765 -80
- Partials 1118 1123 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
refs TryGhost#17065 - This is a follow up cleanup work after introducing even mapper when working on collections refresh mechanism. - This module manages interception of the Model events and maps/dispatches Domain events that could later be used in different libraries.
no issue - Function types in TypeScript can have what looks like an unused variable for the eslint. It's part of the TypeScript language and should be fully supported out of the box.
naz
force-pushed
the
model-domain-event-interceptor
branch
from
3392801
to
52a70b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #17065
🤖 Generated by Copilot at 1d0a031
This pull request introduces a new package
@tryghost/model-to-domain-event-interceptorthat provides a classModelToDomainEventInterceptorfor translating model events to domain events. It also refactors theCollectionsServiceWrapperclass to use this new package, improving the performance and scalability of the collections queries. Additionally, it adds the necessary files and configuration for the new package, such aspackage.json,.eslintrc.js,tsconfig.json,README.md, and unit tests.