Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature flag for page improvements #17176

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Added feature flag for page improvements #17176

merged 1 commit into from
Jul 3, 2023

Conversation

sanne-san
Copy link
Member

No ref

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19 🎉

Comparison is base (3811999) 71.52% compared to head (b440c4e) 71.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17176      +/-   ##
==========================================
+ Coverage   71.52%   71.72%   +0.19%     
==========================================
  Files        1833     1833              
  Lines      116269   116270       +1     
  Branches    17236    17283      +47     
==========================================
+ Hits        83167    83392     +225     
+ Misses      31981    31757     -224     
  Partials     1121     1121              
Flag Coverage Δ
e2e-tests 66.54% <100.00%> (+0.03%) ⬆️
unit-tests 63.55% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ghost/admin/app/services/feature.js 81.35% <ø> (ø)
ghost/core/core/shared/labs.js 95.41% <100.00%> (+0.03%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanne-san sanne-san merged commit 4a6a61b into main Jul 3, 2023
17 checks passed
@sanne-san sanne-san deleted the page-feature-flag branch July 3, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant