Fixed "hidden" icon for feature img/title showing on posts #17180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
force-pushed
the
fix-page-icons-on-posts
branch
from
7d77780
to
838bc0c
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #17180 +/- ##
==========================================
- Coverage 71.73% 71.67% -0.06%
==========================================
Files 1836 1836
Lines 116454 116454
Branches 17291 17269 -22
==========================================
- Hits 83538 83470 -68
- Misses 31794 31863 +69
+ Partials 1122 1121 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
no issue - adjusted conditional to take post type into account - removed usage of `lexicalEditor` feature flag as the flag only adjusts default editor rather than access to the editor (existing lexical posts/pages will always load lexical editor)
kevinansfield
force-pushed
the
fix-page-icons-on-posts
branch
from
991ec09
to
ac90a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
lexicalEditorfeature flag as the flag only adjusts default editor rather than access to the editor (existing lexical posts/pages will always load lexical editor)