Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked CI workflow to optimize setup #17184

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Reworked CI workflow to optimize setup #17184

merged 1 commit into from
Jul 4, 2023

Conversation

daniellockyer
Copy link
Member

@daniellockyer daniellockyer commented Jul 3, 2023

🚧


🤖 Generated by Copilot at d47a03a

This pull request improves the test workflow for the Ghost project by using a new action to restore the caches and a new job to get the metadata. The changes also optimize the workflow by setting some environment variables and using the needs clause. The files .github/workflows/test.yml and .github/actions/restore-cache/action.yml are modified.

@daniellockyer daniellockyer force-pushed the rework-ci branch 7 times, most recently from 36d34e6 to c589ecf Compare July 3, 2023 13:41
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10 🎉

Comparison is base (7f9f467) 71.66% compared to head (adfe15c) 71.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17184      +/-   ##
==========================================
+ Coverage   71.66%   71.76%   +0.10%     
==========================================
  Files        1836     1836              
  Lines      116454   116454              
  Branches    17270    17295      +25     
==========================================
+ Hits        83451    83572     +121     
+ Misses      31884    31761     -123     
- Partials     1119     1121       +2     
Flag Coverage Δ
e2e-tests 66.51% <ø> (+0.06%) ⬆️
unit-tests 63.71% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniellockyer daniellockyer force-pushed the rework-ci branch 22 times, most recently from 5d1f8a1 to 1070a7d Compare July 4, 2023 08:33
@daniellockyer daniellockyer marked this pull request as ready for review July 4, 2023 08:41
refs TryGhost/Toolbox#609

- this rewrites the CI workflow to include a pre-test step which will
  download and cache dependencies, and will only run tests when the
  associated code changes
- this provides a huge improvement over the existing setup, and will
  save us a lot of time in CI
@daniellockyer daniellockyer merged commit 88954f7 into main Jul 4, 2023
22 checks passed
@daniellockyer daniellockyer deleted the rework-ci branch July 4, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant