馃悰Fixed XSS vulnerability involving post excerpts #17190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes TryGhost#17058 - Uses the lodash `escape` function. - Avoids XSS vulnerabilities in post excerpts.
|
I see you merged my patch into a branch somewhere outside of this repo. I was wondering if you had any comments on this PR? This is my first time submitting a PR to this repository (or any non-personal repository for that matter) so I am unfamiliar with what the process is to have my PR accepted and merged. Is there anything more I need to do? Thanks, Joel |
|
@joeldesante thanks for the contribution! Sorry for letting this one sit. |
|
Not a problem at all! Thanks! |
yunaycompany
pushed a commit
to yunaycompany/Ghost
that referenced
this pull request
Dec 14, 2023
closes TryGhost#17058 - Uses the lodash `escape` function. - Avoids XSS vulnerabilities in post excerpts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17058
escapefunction.馃 Generated by Copilot at d347a0a
Fixed a security issue by escaping excerpt text in
excerpt.js. This prevents malicious HTML or scripts from being rendered in the post summaries.