馃悰 Fixed contain/starts/endsWith filters with /, _ or % in them #19015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes GRO-25 Updated @tryghost/nql to 0.12.0 and other packages that depend on it 1. SQLite: when a filter string contains /. When we use a NQL contain/starts/endsWith filter that contains a slash, underlyingly the whole filter will get converted to a MongoDB query, in which we just use a regexp to represent the filter. In here we will escape the slash: \/ as expected in a regexp. Later when we convert this MongoDB query back to knex/SQL, we use a SQL LIKE query. Currently we don't remove the escaping here for a normal slash. MySQL seems to ignore this (kinda incorrect). SQLite doesn't like it, and this breaks queries on SQLite that use slashes. The solution here is simple: remove the backslash escaping when converting the regexp to LIKE, just like we do with other special regexp characters. 2. We don't escape % and _, which have a special meaning in LIKE queries Usage of % and _ is now as expected and doesn't have the special SQL meaning anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes GRO-25
Updated @tryghost/nql to 0.12.0 and other packages that depend on it
When we use a NQL contain/starts/endsWith filter that contains a slash, underlyingly the whole filter will get converted to a MongoDB query, in which we just use a regexp to represent the filter. In here we will escape the slash: / as expected in a regexp. Later when we convert this MongoDB query back to knex/SQL, we use a SQL LIKE query. Currently we don't remove the escaping here for a normal slash. MySQL seems to ignore this (kinda incorrect). SQLite doesn't like it, and this breaks queries on SQLite that use slashes. The solution here is simple: remove the backslash escaping when converting the regexp to LIKE, just like we do with other special regexp characters.
Usage of % and _ is now as expected and doesn't have the special SQL meaning anymore.