🐛 Fixed members import unsubscribing members when subscribe_to_emails is blank
#19658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmraible
commented
Feb 6, 2024
| @@ -14,53 +14,53 @@ const DEFAULT_COLUMNS = [ | |||
| 'tiers' | |||
| ]; | |||
|
|
|||
| const unparse = (members, columns = DEFAULT_COLUMNS.slice()) => { | |||
| const unparse = (rows, columns = DEFAULT_COLUMNS.slice()) => { | |||
There was a problem hiding this comment.
Nitpick but at this point these are just rows in a CSV, not members
cmraible
commented
Feb 6, 2024
| email: row.email, | ||
| name: row.name, | ||
| note: row.note, | ||
| subscribed_to_emails: 'subscribed' in row ? row.subscribed : row.subscribed_to_emails, |
There was a problem hiding this comment.
I'm 99% sure there's no way currently to get a value in row.subscribed, BUT on the off chance I'm missing something here, I changed this up to more explicitly check if the key exists in the row (even if the value is undefined) vs using the || operator.
This allows the expected value (row.subscribed_to_emails) to be undefined instead of coercing it to a boolean.
cmraible
commented
Feb 6, 2024
| @@ -221,6 +221,222 @@ describe('MembersCSVImporter', function () { | |||
| }]); | |||
| should.deepEqual(membersRepositoryStub.update.args[0][1].id, 'test_member_id'); | |||
| }); | |||
|
|
|||
| it('should subscribe or unsubscribe members as per the `subscribe_to_emails` column', async function () { | |||
There was a problem hiding this comment.
A bit verbose and cumbersome, but this one has come up a couple times so I want to just squash it dead.
9larsons
approved these changes
Feb 6, 2024
|
Hard agree! |
…to_emails` is blank on import
cmraible
force-pushed
the
chris-eng-611-importer-issue-blank-subscribed-to-emails-column-is-setting
branch
from
e5e3f72
to
0270228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ENG-611
subscribe_to_emailswas blank/empty, the member would be unsubscribed from all newsletters, which is not the expected behavior.subscribe_to_emailsis blank, it will not unsubscribe existing members.