Switched to default ordering for comments API requests #19774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes ENG-681 There's no need to provide an `order` param with every request in Comments-UI if the API has default ordering that matches our requirements. The order param makes logs more noisy/harder to read than they need to be so we want to get rid of it. - modified comments API input serializer to add a default order param to the browse and replies endpoints when none is provided - removed order param from the requests that Comments-UI makes
allouis
approved these changes
Feb 28, 2024
9larsons
pushed a commit
that referenced
this pull request
Feb 28, 2024
closes ENG-681 There's no need to provide an `order` param with every request in Comments-UI if the API has default ordering that matches our requirements. The order param makes logs more noisy/harder to read than they need to be so we want to get rid of it. - modified comments API input serializer to add a default order param to the browse and replies endpoints when none is provided - removed order param from the requests that Comments-UI makes
allouis
pushed a commit
that referenced
this pull request
Mar 1, 2024
closes ENG-681 There's no need to provide an `order` param with every request in Comments-UI if the API has default ordering that matches our requirements. The order param makes logs more noisy/harder to read than they need to be so we want to get rid of it. - modified comments API input serializer to add a default order param to the browse and replies endpoints when none is provided - removed order param from the requests that Comments-UI makes
allouis
added a commit
that referenced
this pull request
Mar 3, 2024
* upstream/main: (44 commits) v5.80.0 Update dependency yjs to v13.6.14 Update dependency yjs to v13.6.13 Content card design improvements (#19737) Remove comment icon at the top of email template (#19771) ✨ Added lazy-loading of comments data (#19778) Update dependency nodemailer to v6.9.11 🎨 Include archived offers in members filter (#19756) Added /comments/:id/replies/ to X-Cache-Invalidate 🐛 Prevented newsletter subscriptions from getting out of sync in Portal (#19768) Released Comments-UI 0.15.0 (#19775) Switched to default ordering for comments API requests (#19774) Cleaned up comments controller Invalidated post comments cache on like&unlike Invalidated the new comments endpoint cache on add & edit Updated Comments UI to use new endpoint Added endpoint for comments/post/:post_id Added hrefs to paywall links for improved SEO Ensured that endpoint header config is not modified in future 🐛 Fixed cache invalidation header race conditions ...
royalfig
pushed a commit
that referenced
this pull request
Mar 25, 2024
closes ENG-681 There's no need to provide an `order` param with every request in Comments-UI if the API has default ordering that matches our requirements. The order param makes logs more noisy/harder to read than they need to be so we want to get rid of it. - modified comments API input serializer to add a default order param to the browse and replies endpoints when none is provided - removed order param from the requests that Comments-UI makes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ENG-681
There's no need to provide an
orderparam with every request in Comments-UI if the API has default ordering that matches our requirements. The order param makes logs more noisy/harder to read than they need to be so we want to get rid of it.