馃悰 Fixed 500 errors for invalid theme layouts #19848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref ENG-742 ref https://linear.app/tryghost/issue/ENG-742 We don't do any parsing of layouts in gscan, which means themes can be uploaded which use non-existent files for their layout. We can catch the error in the res.render call, and wrap it, just like we do for missing templates (e.g. the StaticRoutesRouter)
allouis
force-pushed
the
egg-eng-742-fix-500-error-when-non-existent-template-is-used
branch
from
bd4afd4
to
1e4cfde
Compare
allouis
deleted the
egg-eng-742-fix-500-error-when-non-existent-template-is-used
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 馃憤 or 馃憥 |
royalfig
pushed a commit
that referenced
this pull request
Mar 25, 2024
ref ENG-742 ref https://linear.app/tryghost/issue/ENG-742 We don't do any parsing of layouts in gscan, which means themes can be uploaded which use non-existent files for their layout. We can catch the error in the res.render call, and wrap it, just like we do for missing templates (e.g. the StaticRoutesRouter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ENG-742
ref https://linear.app/tryghost/issue/ENG-742
We don't do any parsing of layouts in gscan, which means themes can be uploaded which use non-existent files for their layout.
We can catch the error in the res.render call, and wrap it, just like we do for missing templates (e.g. the StaticRoutesRouter)