馃悰 Fixed Admin search sometimes stalling on first query #20143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes https://linear.app/tryghost/issue/MOM-103 - the `yield waitForProperty(...)` call that was supposed to return once the content refresh occurred never reached a valid state so the first search query (or any later query) where a content refresh occurred would never resolve causing search to look like it had stalled - switched to waiting for the last running task to resolve instead which does the same as the previous code intended - exported the `getPosts` request handler function so in mirage config so we can re-use it with different timing on a per-case basis
kevinansfield
added a commit
that referenced
this pull request
May 7, 2024
closes https://linear.app/tryghost/issue/MOM-103 - the `yield waitForProperty(...)` call that was supposed to return once the content refresh occurred never reached a valid state so the first search query (or any later query) where a content refresh occurred would never resolve causing search to look like it had stalled - switched to waiting for the last running task to resolve instead which does the same as the previous code intended - exported the `getPosts` request handler function so in mirage config so we can re-use it with different timing on a per-case basis
sagzy
pushed a commit
that referenced
this pull request
May 7, 2024
closes https://linear.app/tryghost/issue/MOM-103 - the `yield waitForProperty(...)` call that was supposed to return once the content refresh occurred never reached a valid state so the first search query (or any later query) where a content refresh occurred would never resolve causing search to look like it had stalled - switched to waiting for the last running task to resolve instead which does the same as the previous code intended - exported the `getPosts` request handler function so in mirage config so we can re-use it with different timing on a per-case basis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/tryghost/issue/MOM-103
yield waitForProperty(...)call that was supposed to return once the content refresh occurred never reached a valid state so the first search query (or any later query) where a content refresh occurred would never resolve causing search to look like it had stalledgetPostsrequest handler function so in mirage config so we can re-use it with different timing on a per-case basis