Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config to hide labels from the signup card for contributors #20429

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

sagzy
Copy link
Contributor

@sagzy sagzy commented Jun 20, 2024

ref https://linear.app/tryghost/issue/SLO-127

  • problem: contributors see an empty list of labels in the Signup card, even if some exist
  • cause: contributors do not have permission to browse labels
  • solution: hide the label input entirely for contributors in the Signup card, based on the new renderLabels config parameter

ref https://linear.app/tryghost/issue/SLO-127

- as contributors do not have permissions to browse labels, the label list on the signup card is empty (HTTP 403)
- instead of showing an empty list to contributors, we want to hide the field entirely
@github-actions github-actions bot added the affects:admin Anything relating to Ghost Admin label Jun 20, 2024
@sagzy sagzy enabled auto-merge (squash) June 24, 2024 14:05
@sagzy sagzy merged commit b924027 into main Jun 24, 2024
22 checks passed
@sagzy sagzy deleted the fix-labels-list-not-loading-for-contributors branch June 24, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant