Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the showdown extensions #2384

Merged
merged 1 commit into from Mar 20, 2014
Merged

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Mar 10, 2014

Improving the showdown extensions
issue #2381, issue #2312

  • renamed the ghost extensions
  • added typography to the tests so we can see what is broken
  • added new html tests
  • commented out typography / removed it from use because it is currently
    too broken

@ErisDS ErisDS added this to the 0.4.2 milestone Mar 13, 2014
@ErisDS
Copy link
Member Author

ErisDS commented Mar 19, 2014

This now fixes #2312. I've tried updating typography to the latest version, but it still breaks our tests. I'm going to try to recreate those tests in typography and get them fixed but it will have to wait a bit.

@ErisDS ErisDS changed the title [WIP] Starting to improve the showdown extensions Starting to improve the showdown extensions Mar 19, 2014
@ErisDS ErisDS changed the title Starting to improve the showdown extensions Improving the showdown extensions Mar 19, 2014
fixes TryGhost#2381

- renamed the ghost extensions
- added new html tests
ErisDS added a commit that referenced this pull request Mar 20, 2014
Improving the showdown extensions
@ErisDS ErisDS merged commit 8bca485 into TryGhost:master Mar 20, 2014
@ErisDS ErisDS deleted the showdown-refactor branch May 3, 2014 17:32
tigefa4u pushed a commit to tigefa4u/Ghost that referenced this pull request Aug 3, 2022
refs: TryGhost/Product#1625

- we want to remove backwards compatibility code for slack being a single setting

Co-authored-by: Rishabh <zrishabhgarg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant