Cleanup modules Sass #4342
Merged
Cleanup modules Sass #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for feedback & discussion on this. It'll help shape how we do Sass/CSS in the future. |
| $rounded: 3px; | ||
| $shadow: rgba(0,0,0,0.05) 0 1px 5px; | ||
| $default-transition-duration: 0.3s; | ||
| $side-outlet-transition-duration: 0.4s; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Looks good. I think some of these commits can be combined though. Commits 2, 3, 4, 6, and 8 can all be squashed into "var cleanup". 1 and 7 can be squashed into file structure cleanup. 5 can live on its own |
Also introduces a new format of file opening comment, to outline what happens and a contents list.
|
Pending tests, this is now GTG. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #4107
This is the first step in a larger project to reformat our Sass. Each 'chunk' will reformat a directory in
core/client/assets/sass.The main changes here are:
helpers->moduleslib->vendor(a common practice from JS dev)