Implement Navigation item input behaviors #4826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaswilli as the person who implemented this - did it feel intuitive? I'm looking forward to playing with it and finding out for myself, but wondered what you thought :) |
|
Just taken this for a spin. Seems to work perfectly! Feels intuitive for me too. I'm still not convinced that showing one blank row on the bottom is a great idea though, but that's another issue. |
|
It feels pretty natural when you run through it, everything pretty much works like you'd expect it to, I think. |
ErisDS
added a commit
that referenced
this pull request
Jan 20, 2015
Implement Navigation item input behaviors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4807