Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember to 1.12.1 and Ember-Data to 1.0.0-beta.18 #5380

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

acburdine
Copy link
Member

No issue

  • fixed "{{#each}}" helper in templates to use block syntax
  • fixed deprecated ember.controller getter/setter function to use new syntax

@acburdine
Copy link
Member Author

Currently this will still throw a deprecation error for some of the initializers. To fix this I need to change some of them to be instance-initializers, but I am going to put that in with the ember-cli update, as there's a resolver module update that needs to happen.

@jaswilli
Copy link
Contributor

jaswilli commented Jun 3, 2015

Can you split out the removal of the prototype extension usage into a separate piece of work? When there are library updates it's much easier to troubleshoot if they've been upgraded in isolation.

@acburdine
Copy link
Member Author

@jaswilli Done.

@jaswilli
Copy link
Contributor

jaswilli commented Jun 3, 2015

Looks pretty good. There are a handful of typeKey -> modelName conversions that were missed though (git grep typeKey).

No issue
- fixed "{{#each}}" helper in templates to use block syntax
- fixed deprecated ember.controller getter/setter function to use new syntax
- removed unnecessary pass-protect route view
@acburdine
Copy link
Member Author

Those didn't initially throw deprecation errors....probably because they weren't used 😄

jaswilli added a commit that referenced this pull request Jun 3, 2015
Update Ember to 1.12.1 and Ember-Data to 1.0.0-beta.18
@jaswilli jaswilli merged commit 5ec1979 into TryGhost:master Jun 3, 2015
@acburdine acburdine deleted the ghost-ember112 branch June 3, 2015 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants