Serve immediate 404 for static files (no fallthru) #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this pull request
Oct 11, 2015
refs TryGhost#5286, TryGhost#4172, TryGhost#5888 - no need to pass blogApp around in middleware - improve test coverage to 100%
ErisDS
force-pushed
the
improve-fileserve
branch
from
ce91e00
to
ed144f8
Compare
closes TryGhost#5887 - make use of the new 'fallthrough' option which landed in express-static 1.10.0 - change local-file-store and middleware serving `/public/` and `/shared/` files to use the new `fallthrough: false` option - 404s are now served directly, without slashes or uncapitalise getting triggered
ErisDS
force-pushed
the
improve-fileserve
branch
from
ed144f8
to
a59cfc7
Compare
ErisDS
changed the title
|
This is ready for primetime. There are some additional todos:
I'll raise these as separate issues, with an idea of what to do. I had been letting those TODOs block this, which is dumb cos this is a great improvement all on its own. |
|
This test failure seems to be genuine :-/. |
|
The error I saw was the same as the one reported in #6550
It's an ongoing issue but not related to this PR |
sebgie
added a commit
that referenced
this pull request
Feb 23, 2016
Serve immediate 404 for static files (no fallthru)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to take this for a proper spin, but I'm quite excited by this improvement!
closes #5887
/public/and/shared/files to use the newfallthrough: falseoption