Remove unused base_test.js #6136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhops Good catch 🎣 and thanks for taking the time to write a clear explanation on the PR, that really helps make my merge-life easier 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
core/test/functional/routes/api/base_test.jswhich was implemented at one point to verify that a 405 was returned when an invalid method is used on a route. This functionality was later removed in this commit, however the tests were never removed.These tests should actually be failing, however the file does match
*_spec.jsso it is never executed in the test suite.For the sake of clarity, I feel as though this file should be removed.