cleanup usage of Ember.inject

[acburdine]

no issue

cleans up some const usage of Ember.inject and a couple of other Ember globals

[acburdine]

@kevinansfield Not sure if this is needed/wanted at all, I just noticed this pattern in ember-ajax and thought it might clean up the code a little bit

[kevinansfield]

👍 Looks like a nice improvement! A couple of things:

1. It would be good to standardise how we call service(), either always specifying the name, e.g. notifications: service('notifications') or only specifying the name when needed, notifications: service(). I'm leaning towards only specifying it when needed, in which case the ghost-paths and slug-generator service injects can be cleaned up.
2. computed is a bit of an odd one for the destructed assignment as it is both used directly computed() and has descendants computed.alias(), as such I think we should stick to this format everywhere so there's no confusion about when to use const { computed: {alias} } vs const { computed } = Ember; const { alias } = computed:

const {
    computed
} = Ember;

const {
    alias,
    filter
} = computed;

[acburdine]

Sounds good! Will re-do this a bit later today.