Update Post Slug while Draft on Title Changes #6631
Conversation
| @@ -139,9 +139,10 @@ Post = ghostBookshelf.Model.extend({ | |||
| } | |||
| } | |||
|
|
|||
| if (this.hasChanged('slug') || !this.get('slug')) { | |||
| // If the status is not published and has never been published (published at never been set), update slug with title | |||
| if (this.get('status') === 'draft' && !this.get('published_at')) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I haven't tested it yet but it looks as though when a user manually changes the slug before publishing then those changes are overwritten and a new slug based on the title is used instead? My understanding of the solution for #5062 was to only overwrite the slug if the user hasn't manually changed it by comparing the slug against the output from the title->slug generator. |
|
ahh, ya forgot about that, thanks |
Closes #5062 * As long as the post has never been published, update the slug to match the new title if the title is changed
|
should be good to go now |
|
LGTM and works well 👍 |
|
I think the model logic here is looking good to merge. Just wondering though - should there be a frontend piece to go with this? E.g. on title changes if the post is a draft, resend the slug request? This would let the slug update in the background without a save, as autosaves are not triggered by the title field. |
This is similar to Ghost's in-built slug update logic since 0.8.0 (see TryGhost/Ghost#6631), with some differences: - The slug is updated even if a post is unpublished and then published again with a new title - The slug is only updated on publish, not on every save - If a custom slug was set on the draft, it will be overridden upon publishing Refs: #122, #130
Closes #5062
match the new title if the title is changed