Recommend Node v4 & use as default #7102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#7098 - Use Node.js v4 as our default build environment - Add Node.js v6 as an allowed failure - Update contributor guidelines and readme - Fix issue with branch exceptions
ErisDS
force-pushed
the
recommend-node-v4
branch
from
d30b426
to
9303cb8
Compare
chris-brown
pushed a commit
to chris-brown/Ghost
that referenced
this pull request
Aug 14, 2016
refs TryGhost#7098 - Use Node.js v4 as our default build environment - Add Node.js v6 as an allowed failure - Update contributor guidelines and readme - Fix issue with branch exceptions
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
refs TryGhost#7098 - Use Node.js v4 as our default build environment - Add Node.js v6 as an allowed failure - Update contributor guidelines and readme - Fix issue with branch exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these changes are purely cosmetic e.g. the Node version in the Contributing guide bug report, some of them are documentation updates E.g. changes in the README and others are functional e.g. changes to .travis.yml
With this PR, we switch over our recommendation from Node.js 0.10 to v4 LTS. This means that v4 is our default environment now: what we use for development, testing & in production.
Node.js 0.10 is still supported and expected to work until 1st October 2016.
With this PR we also and Node v6 as an allowed failure (and the build does fail right now). So that we can start to figure out what needs to be done to ensure we have support for it when it is declared LTS also on 1st October 2016.
Note: This pulls in the latest Ghost-Admin master which has similar changes
refs #7098