improvement: validate timezones #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
improvement/validate-timezones
branch
from
228b905
to
0f39f38
Compare
kirrg001
changed the title
no issue - add isTimezone to schema validation
kirrg001
force-pushed
the
improvement/validate-timezones
branch
from
0f39f38
to
dd55960
Compare
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Jul 26, 2016
refs TryGhost/Ghost#7142, TryGhost/Ghost#7143 - moves timezone selection template and logic into a component - detect if the current `activeTimezone` is not in our pre-defined list of timezones, if it isn't: - add a line indicating that there has been a manual override with the current `activeTimezone` value - add a blank option to the timezone select list
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Jul 26, 2016
refs TryGhost/Ghost#7142, TryGhost/Ghost#7143 - moves timezone selection template and logic into a component - detect if the current `activeTimezone` is not in our pre-defined list of timezones, if it isn't: - add a line indicating that there has been an override with the current `activeTimezone` value - add a blank option to the timezone select list
chris-brown
pushed a commit
to chris-brown/Ghost
that referenced
this pull request
Aug 14, 2016
no issue - add isTimezone to schema validation
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
no issue - add isTimezone to schema validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
Validate timezones before saving to the database.
Right now: it is possible to set any value for
activeTimezone. That results in an unwanted state ofmoment, because it complains that the given timezone is unknown. This PR adds validation to the schema - so you can only save timezones which are available (we check against the timezones json file)