Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha to version 3.0.2 πŸš€ #7165

Merged
merged 2 commits into from Aug 11, 2016
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

mocha just published its new version 3.0.0.

State Update πŸš€
Dependency mocha
New version 3.0.0
Type devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of mocha.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 107 commits .

  • e8cda73 Release v3.0.0
  • 4944e31 rebuild mocha.js
  • 16762d1 fix bad merge of karma.conf.js
  • 2f9a409 add note about spec reporter to CHANGELOG.md [ci skip]
  • 7c0284b fixed typo in mocha.css introduced by 185c0d902e272216232630fe4e2577268456dd9a [ci skip]
  • 8741506 Remove carriage return before each test line in spec reporter. Served no purpose
  • 309b8f2 add "logo" field to package.json [ci skip]
  • 740a511 fix incorrect executable name with new version of commander
  • 0e2e49b add bower.json to published package for npmcdn support [ci skip]
  • d367bc7 fix broken/wrong URLs in CHANGELOG.md [ci skip]
  • 6184529 Release v3.0.0-2
  • 4b4009b rebuild mocha.js
  • 15c344c add browser-stdout to dependencies
  • e3ab4ec update CHANGELOG [ci skip]
  • 0cd9dc9 let child suites run if parent is exclusive; closes #2378 (#2387)

There are 107 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚑ greenkeeper upgrade

@acburdine
Copy link
Member

Errors are because Mocha 3 doesn't like returning a promise and using done() at the same time, fix incoming.

@acburdine
Copy link
Member

acburdine commented Aug 1, 2016

Fixed all the duplicate done/promise handling that was causing tests to fail. Will create an issue for refactoring the tests to use Promises when possible. EDIT: issue #7166 is that issue πŸ˜„

tl;dr this should be good to go

/cc @kirrg001 @ErisDS

@acburdine acburdine changed the title Update mocha to version 3.0.0 πŸš€ Update mocha to version 3.0.2 πŸš€ Aug 10, 2016
@ErisDS ErisDS merged commit dd5775c into master Aug 11, 2016
@ErisDS ErisDS deleted the greenkeeper-mocha-3.0.0 branch August 11, 2016 07:51
chris-brown pushed a commit to chris-brown/Ghost that referenced this pull request Aug 14, 2016
* chore(package): update mocha to version 3.0.2

https://greenkeeper.io/

* fix duplicate done/promise handling
mixonic pushed a commit to mixonic/Ghost that referenced this pull request Oct 28, 2016
* chore(package): update mocha to version 3.0.2

https://greenkeeper.io/

* fix duplicate done/promise handling
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this pull request Nov 20, 2016
* chore(package): update mocha to version 3.0.2

https://greenkeeper.io/

* fix duplicate done/promise handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants