馃拕 Ensure all middleware use named functions #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue - anonymous functions are hard to debug in memory traces etc - having anonymous middleware functions makes it hard to inspect or debug the middleware stack (something I like to do) - these 2 are the only ones atm, including all 3rd party middleware
mixonic
pushed a commit
to mixonic/Ghost
that referenced
this pull request
Oct 28, 2016
no issue - anonymous functions are hard to debug in memory traces etc - having anonymous middleware functions makes it hard to inspect or debug the middleware stack (something I like to do) - these 2 are the only ones atm, including all 3rd party middleware
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
no issue - anonymous functions are hard to debug in memory traces etc - having anonymous middleware functions makes it hard to inspect or debug the middleware stack (something I like to do) - these 2 are the only ones atm, including all 3rd party middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick little commit to name two middleware functions that were previously anonymous.
Super useful when inspecting and debugging the middleware stack, which I have been doing with a little stack printing tool I wrote: https://github.com/ErisDS/middleware-stack-printer
A full stack print for the home route in Ghost (with this change) can be found in this gist.
It's kinda huge 馃槼
no issue