馃帹 unique constraint for permission and role name #7674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue I saw tests adding permissions and roles twice. (see screenshots) That happened because the setup in the test was mis-used and there is no restriction for static resources to create duplicates. With this PR i suggest to make name unique.
|
This PR needs a review before #7495 |
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
refs TryGhost#7494, refs TryGhost#7495 I saw tests adding permissions and roles twice. (see screenshots) That happened because the setup in the test was mis-used and there is no restriction for static resources to create duplicates. With this PR i suggest to make name unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
I saw tests adding permissions and roles twice. (see screenshots)
That happened because the setup in the test was mis-used and there is no restriction for static resources to create duplicates. We also have a unique constraint for settings keys.
With this PR i suggest to make name unique.