🎨 config optimisations #7921
Merged
🎨 config optimisations #7921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
tests/config-hierarchy
branch
from
1bb2a41
to
fbee967
Compare
kirrg001
changed the title
kirrg001
force-pushed
the
tests/config-hierarchy
branch
from
fbee967
to
b7ca410
Compare
kirrg001
changed the title
refs TryGhost#7488 - rename file keys for config files, see https://github.com/TryGhost/Ghost/pull/7493/files - add tests to avoid running into config hierarchy problems again - overrides.json is the strongest! - argv/env can override any default - custom config can override defaults - reorganise util functions for config again
kirrg001
force-pushed
the
tests/config-hierarchy
branch
from
b7ca410
to
8f207c7
Compare
ErisDS
reviewed
Feb 2, 2017
| /** | ||
| * no channel can override the overrides | ||
| */ | ||
| nconf.file('overrides', path.join(baseConfigPath, 'overrides.json')); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This was super nice for testing 👍 and I think it will be awesome for debugging later as well. Nice! I have tested a few things with hierarchy of the config and nested values and it all behaves as expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7488
We have added an ugly fix see https://github.com/TryGhost/Ghost/pull/7493/files.
This PR removes the ugly fix and much more
DEBUG=ghost:configto display all config values on bootstrapThe reviewer should play with config hierarchy a little to ensure i didn't forget a case.