Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor long switch statement: #8230

Closed

Conversation

roramirez
Copy link

Minimize code getContentPath in function of utils of core server.

Minimize code getContentPath in function of utils of core server.
@ErisDS
Copy link
Member

ErisDS commented Apr 4, 2017

Hi @roramirez, I appreciate the intention to contribute, however this is not a PR that we would merge. It is based too heavily in individual preference and this kind of thing tends to open the door to bikeshed-style debates that are not a good use of time.

Besides, there is discussion elsewhere about removing this concept entirely.

If you're looking for a way to get over the barrier to first contribution, I highly recommend checking out the beginner label. There is also a fix-wanted and backlog label that we don't use as consistently as we should, these generally mean issues we aren't intending to fix ourselves.

@ErisDS ErisDS closed this Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants