🎨 change location of adapters #8286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#7687 - change location from content/storage or content/scheduling to content/adapters/storage or content/adapters/scheduling - i have added a @todo to TryGhost#7421 to check if both adapter types needs an update in the documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7687
Note: we could do way more for adapter improvements e.g. transform scheduling into classes and source out scheduling base, but scheduling is right now not a candidate for having lot's of custom adapters available. We build a good JavaScript solution, people usually use as default. Furthermore, we could group the default adapters into one folder e.g.
core/server/adapters. But as we would like to re-group our folders anyway, we can do that after1.0launch. Or pre launch1.0?