Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: minor refactors #9104

Merged
merged 6 commits into from
Oct 5, 2017
Merged

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Oct 5, 2017

This PR includes cleanup, refactors & renaming to check off 3 items from #9043. The aim is to make it easier to understand the code. Can use this PR description as squashed commit message 馃惪

refs #9043

Cleanups / refactors to make the code more manageable:

  • Move remaining code out of index.js
    • Only "init" function is left. Actions map cache and init function is based heavily on the settings cache module
  • refactor the odd way of exporting
    • This was cleaned up naturally by moving the actionsMap object out
  • rename "effective" -> "providers"
    • "Providers" provide permissions for different things that can have permissions (users, apps, in future clients).

- needed to fix how they were done, as they were dependent on order
- fix problem with clobbering fixtures & tests only working in certain orders
@kirrg001 kirrg001 merged commit 6760ccc into TryGhost:master Oct 5, 2017
@ErisDS ErisDS deleted the perms-improve branch October 6, 2017 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants