Introduced renderer to DRY up controllers #9235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#5091, TryGhost#9192 - Renderer figures out templates, contexts, and does a render call - Renderer will handle everything after data is fetched and semi-processed - For now it only does the last 2 steps - TODO: it will eventually do more steps!!
- Templating is now handled with a single function - Introduces a res.locals.route object for config - not sure about this yet!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces code duplication all over the codebase and introduces a couple of new concepts - I'm not 100% about them yet so they kind of have temporary names :) Over the next few commits hopefully the concepts will solidify and things will get real names.
To start, we now have a renderer. This has the job of handling everything that happens once we've got our data ready to render:
res.locals.contextres._templateres.render.Most interestingly, to make this work, all controllers now define a little bit of config, currently stored in
res._route. (That's a totally temporary location, as isres._template... when a sensible naming convention reveals itself I'll get rid of the weird_). This exposes atypeand for custom routes a template name & default.I have a plan to move this forward into a more standardised concept of controllers. This changeset makes sense on its own for now tho...
refs #5091, #9192