🗜 Set soft limits for blog title and description #9250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#8143 Add max length validations to settings: - `blog.title`: 150 chars - `blog.description`: 200 chars The `validateSettings` fn in our validations checks for existing `validations` properties in our `default-settings.json` file, similar to other tables in our `schema.js`.
|
This definitely needs client validation as well, which is currently not in place. Without those, the client returns the error that the setup was already completed. PR for this is coming. The server side implementation of the two new soft limits work for the setup flow, as changing the title and description in settings. |
|
Where are the limits are coming from? 150 and 200? I can't find it. |
|
Okay i got confused because of your comment
|
Ah, sorry. Client validation was missing for the setup flow only!! |
|
Here's the mentioned client PR: TryGhost/Admin#909 |
kirrg001
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8143
Add max length validations to settings:
blog.title: 150 charsblog.description: 200 charsThe
validateSettingsfn in our validations checks for existingvalidationsproperties in ourdefault-settings.jsonfile, similar to other tables in ourschema.js.