Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordered error logging on ghost start #9440

Merged
merged 1 commit into from Feb 4, 2018

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Feb 3, 2018

no issue

  • if we trigger the IPC message to the CLI and the process manager is systemd, systemd will restart Ghost too early (same for local process manager) - this is a timing issue
  • the consequence is that the error log won't happen in Ghost (content/logs/[domain].error.log won't contain that error)
  • let's reorder both executions

See this comment on the CLI PR.

no issue

- if we trigger the IPC message to the CLI and the process manager is systemd, systemd will restart Ghost too early
- the consequence is that the error log won't happen in Ghost (content/logs/[domain].error.log) won't contain that error
- let's reorder both executions
Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kirrg001 kirrg001 merged commit f9d4d01 into TryGhost:master Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants