Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump markdown-it to 8.4.1, so uc.micro bumps to 1.0.5 and it is now MIT licensed #9484

Merged
merged 2 commits into from Mar 5, 2018

Conversation

silviofdez
Copy link

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

uc.micro npm package had a WTFL prior to 1.0.5 version, this package is a dependency for markdown-it, which is a dependency of Ghost itself.

If we bump markdown-it from 8.4.0 to 8.4.1, then uc.micro bump from 1.0.3 to 1.0.5 and all the components/packages included installing Ghost have a License OSI approved.

This is important because there are certain cloud providers that do not allow to publish software with WTFL license

  • [ X ] There's a clear use-case for this code change
  • [ X ] Commit message has a short title & references relevant issues
  • [ X ] The build will pass (run npm test)

More info can be found by clicking the "guidelines for contributing" link above.

@kirrg001
Copy link
Contributor

kirrg001 commented Mar 2, 2018

I'll look into failing tests soon. Looks like their is a bug in our tests.

@silviofdez
Copy link
Author

Thanks @kirrg001 , please let me know if there is something I can help on my side.

@kirrg001
Copy link
Contributor

kirrg001 commented Mar 4, 2018

@silviofdez Could you pls rebase against master? The tests should then pass 👍

@silviofdez
Copy link
Author

@kirrg001 rebased (using this guide: https://help.github.com/articles/syncing-a-fork/), but still some tests failing

@kirrg001
Copy link
Contributor

kirrg001 commented Mar 5, 2018

@silviofdez I've restarted the build. Travis is sometimes super slow in the evening and the chance that builds fail randomly is higher than normal. Let see if it passes now.

@silviofdez
Copy link
Author

Thanks @kirrg001 , all green now!!! 😄

@kirrg001
Copy link
Contributor

kirrg001 commented Mar 5, 2018

@silviofdez 😀That really took long. Travis is out of control. Thanks again for your PR!

@kirrg001 kirrg001 merged commit 043370d into TryGhost:master Mar 5, 2018
@silviofdez silviofdez mentioned this pull request Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants