Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log "Building client" message until client build finishes with grunt dev #9611

Merged
merged 1 commit into from Apr 30, 2018
Merged

Log "Building client" message until client build finishes with grunt dev #9611

merged 1 commit into from Apr 30, 2018

Conversation

kevinansfield
Copy link
Contributor

no issue

  • display "Building admin client... (can take ~1min)" every 5 seconds when running grunt dev until the ember build finishes so that it's clear the command is still busy
❯ grunt dev
Running "dev" task

Running "clean:built" (clean) task
>> 0 paths cleaned.

Running "bgShell:client" (bgShell) task
Building admin client... (can take ~1min)

Running "express:dev" (express) task
Starting background Express server
[2018-04-30 14:06:39] WARN Theme's file locales/en.json not found. 
[2018-04-30 14:06:39] INFO Ghost is running in development... 
[2018-04-30 14:06:39] INFO Listening on: 127.0.0.1:2368 

Running "watch" task
Waiting...
[2018-04-30 14:06:39] INFO Url configured as: http://ghost.blog/ 
[2018-04-30 14:06:39] INFO Ctrl+C to shut down 
[2018-04-30 14:06:39] INFO Ghost boot 1.668s 
Running "subgrunt:watch" (subgrunt) task
Running "shell:ember:watch" (shell) task
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-cli-active-link-wrapper -> ember-cli-babel
Building admin client... (can take ~1min)
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-drag-drop -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-element-resize-detector -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-light-table -> ember-in-viewport -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-light-table -> ember-in-viewport -> ember-getowner-polyfill -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-light-table -> ember-scrollable -> ember-component-inbound-actions -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-light-table -> ember-scrollable -> ember-element-resize-detector -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ghost-admin -> ember-responsive -> ember-getowner-polyfill -> ember-cli-babel
Building admin client... (can take ~1min)
Building admin client... (can take ~1min)
Building admin client... (can take ~1min)
Building admin client... (can take ~1min)
Building admin client... (can take ~1min)
Building admin client... (can take ~1min)
Building admin client... (can take ~1min)

Build successful (28770ms) – Serving on http://localhost:4200/



Slowest Nodes (totalTime => 5% )              | Total (avg)         
----------------------------------------------+---------------------
PostcssCompiler (2)                           | 6648ms (3324 ms)    
Babel (102)                                   | 3567ms (34 ms)      
Concat (13)                                   | 3169ms (243 ms)     
AssetRewrite (2)                              | 3026ms (1513 ms)    
EslintValidationFilter (5)                    | 2858ms (571 ms)     
ember-browserify (2)                          | 2148ms (1074 ms)

@kevinansfield
Log "Building client" message until client build finishes
803b691 
no issue
- display "Building admin client... (can take ~1min)" every 5 seconds when running `grunt dev` until the ember build finishes so that it's clear the command is still busy
kirrg001
kirrg001 reviewed Apr 30, 2018
View reviewed changes
Gruntfile.js
@@ -217,6 +228,10 @@ var config = require('./core/server/config'),
if (!filter) {
grunt.log.write(chunk);
}

if (chunk.indexOf('Build successful') !== -1) {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@kirrg001 kirrg001 merged commit eef2d0b into TryGhost:master Apr 30, 2018
@kevinansfield kevinansfield deleted the grunt-dev-log-client-build branch May 3, 2018 12:01
kevinansfield added a commit that referenced this pull request May 3, 2018
@kevinansfield
Cancel repeating client build log on build error
58aa531 
refs #9611
- #9611 added a repeating message to `grunt dev` output whilst waiting for a successful build but there was no handling for failed builds
- modify bgShell config to cancel the repeating message when there is output on the `stderr` pipe from `ember-cli`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirrg001 kirrg001 kirrg001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinansfield @kirrg001