Es6 migration for web/middleware #9737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) Will review on Monday! |
kirrg001
reviewed
Jul 23, 2018
| @@ -107,7 +106,7 @@ _private.ThemeErrorRenderer = function ThemeErrorRenderer(err, req, res, next) { | |||
| // It can be that something went wrong with the theme or otherwise loading handlebars | |||
| // This ensures that no matter what res.render will work here | |||
| // @TODO: split the error handler for assets, admin & theme to refactor this away | |||
| if (_.isEmpty(req.app.engines)) { | |||
| if (req.app.engines.length === 0) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
suggested changes
Jul 23, 2018
mandeepm91
reviewed
Aug 1, 2018
| @@ -107,7 +106,7 @@ _private.ThemeErrorRenderer = function ThemeErrorRenderer(err, req, res, next) { | |||
| // It can be that something went wrong with the theme or otherwise loading handlebars | |||
| // This ensures that no matter what res.render will work here | |||
| // @TODO: split the error handler for assets, admin & theme to refactor this away | |||
| if (_.isEmpty(req.app.engines)) { | |||
| if (Object.keys(req.app.engines).length === 0) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
force-pushed
the
larsnolden-issue_9589
branch
from
581e273
to
9f8284b
Compare
rishabhgrg
pushed a commit
to rishabhgrg/Ghost
that referenced
this pull request
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9589
Changed the files
in the web/middleware folder and the web/admin, web/api files.