Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 Added Koenig Demo Post #9747

Merged
merged 3 commits into from
Jul 24, 2018
Merged

馃帹 Added Koenig Demo Post #9747

merged 3 commits into from
Jul 24, 2018

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Jul 23, 2018

no issue

  • add new migration for 1.25 to insert the draft demo post
  • tested on sqlite3 + mysql
  • add the new demo post to our fixtures to ensure a new blog get's the demo post as well
  • ensure demo post is never inserted twice

  • add handling if ghost author user doesn't exist anymore

@kirrg001 kirrg001 force-pushed the demo-post branch 2 times, most recently from 8afba02 to a0875e7 Compare July 23, 2018 17:18
@kirrg001 kirrg001 changed the title [WIP] Added demo post [WIP] Added K枚nig Demo Post Jul 23, 2018
@kirrg001 kirrg001 changed the title [WIP] Added K枚nig Demo Post [WIP] 馃帹Added K枚nig Demo Post Jul 23, 2018
@kirrg001 kirrg001 changed the title [WIP] 馃帹Added K枚nig Demo Post [WIP] 馃帹 Added K枚nig Demo Post Jul 23, 2018
@kirrg001 kirrg001 changed the title [WIP] 馃帹 Added K枚nig Demo Post 馃帹 Added K枚nig Demo Post Jul 23, 2018
"meta_description": null,
"created_by": "5951f5fca366002ebd5dbef7",
"published_by": null,
"author_id": "5951f5fca366002ebd5dbef7"

This comment was marked as abuse.

This comment was marked as abuse.

@kirrg001 kirrg001 changed the title 馃帹 Added K枚nig Demo Post [WIP] 馃帹 Added K枚nig Demo Post Jul 23, 2018
no issue

- add new migration for 1.25 to insert the draft demo post
- tested on sqlite3 + mysql
- add the new demo post to our fixtures to ensure a new blog get's the demo post as well
- added handling if Ghost Author user doesn't exist anymore
@kirrg001 kirrg001 changed the title [WIP] 馃帹 Added K枚nig Demo Post 馃帹 Added K枚nig Demo Post Jul 23, 2018
@kirrg001 kirrg001 changed the title 馃帹 Added K枚nig Demo Post [WIP] 馃帹 Added Koenig Demo Post Jul 23, 2018
@kirrg001 kirrg001 changed the title [WIP] 馃帹 Added Koenig Demo Post 馃帹 Added Koenig Demo Post Jul 23, 2018
Copy link
Contributor

@kevinansfield kevinansfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the demo post slug and improved skip message everything else here looks 馃憤 Tested on sqlite and it worked well.

@@ -358,6 +358,20 @@
{
"name": "Post",
"entries": [
{
"title": "Koenig Demo Post",
"slug": "koenig-demo-post",

This comment was marked as abuse.

const fixtures = require('../../../../data/schema/fixtures');
const message1 = 'Adding demo post.';
const message2 = 'Added demo post.';
const message3 = 'Skip: Adding demo post.';

This comment was marked as abuse.

@kirrg001
Copy link
Contributor Author

@kevinansfield Can i merge this? :)

@kevinansfield
Copy link
Contributor

@kirrg001 yes, sorry, missed the notifications 馃檲

@kirrg001 kirrg001 merged commit 76b9a49 into TryGhost:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants