Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised 6th migration script (fixture posts replacement) #9812

Merged
merged 1 commit into from Aug 22, 2018

Conversation

kirrg001
Copy link
Contributor

no issue

  • do only look for published old fixture posts
    • otherwise we detect draft old fixture post
    • and then we would replace them with published new fixture posts, which is not a very nice experience
  • ensure, if we have found all old fixture posts, replace all of them with the correct date
    • otherwise they are getting replaced and the date is now
  • this migration script is tricky and it tries to be smart, but there are so many cases we can run into
  • to remember: the goal was to replace old with new fixture posts (e.g. you just installed 1.25, but 2.0 is out and you migrate straight)
  • added more protection to ensure we don't delete custom posts

no issue

- do only look for published old fixture posts
  - otherwise we detect draft old fixture post
  - and then we would replace them with published new fixture posts, which is not a very nice experience
- ensure, if we have found all old fixture posts, replace all of them with the correct date
  - otherwise they are getting replaced and the date is now
- this migration script is tricky and it tries to be smart, but there are so many cases we can run into
- to remember: the goal was to replace old with new fixture posts (e.g. you just installed 1.25, but 2.0 is out and you migrate straight)
- added more protection to ensure we don't delete custom posts
@kirrg001 kirrg001 self-assigned this Aug 22, 2018
@kirrg001 kirrg001 merged commit 91950cf into TryGhost:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant