Fixed redirect issue with private sites #9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
approved these changes
Oct 8, 2018
closes #9959 This issue existed because the logic assumed that if there were no query parameters then there would be no `query` object. However this is not the case. What we really wanted to check was for the existence of an "r" query param - the code has been refactor to explicitly do this now.
allouis
added a commit
that referenced
this pull request
Nov 7, 2018
closes #9959 This issue existed because the logic assumed that if there were no query parameters then there would be no `query` object. However this is not the case. What we really wanted to check was for the existence of an "r" query param - the code has been refactor to explicitly do this now.
allouis
added a commit
that referenced
this pull request
Nov 7, 2018
* 1.x: Version bump to 1.25.6 Updated Ghost-Admin to 1.25.6 Fixed sanitization issue in subscribers 🐛 Fixed redirect issue with private sites (#9960) Updated private-sites to not redirect to full urls
kirrg001
added a commit
to kirrg001/Ghost
that referenced
this pull request
Nov 7, 2018
closes TryGhost#9959 This issue existed because the logic assumed that if there were no query parameters then there would be no `query` object. However this is not the case. What we really wanted to check was for the existence of an "r" query param - the code has been refactor to explicitly do this now.
kirrg001
added a commit
that referenced
this pull request
Nov 7, 2018
closes #9959 This issue existed because the logic assumed that if there were no query parameters then there would be no `query` object. However this is not the case. What we really wanted to check was for the existence of an "r" query param - the code has been refactor to explicitly do this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9959
This issue existed because the logic assumed that if there were no
query parameters then there would be no
queryobject. However this isnot the case. What we really wanted to check was for the existence of an
"r" query param - the code has been refactor to explicitly do this now.