Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed current format being lost on an inserted emoji #1038

Merged

Conversation

kevinansfield
Copy link
Contributor

no issue

  • apply the current selection's format to the newly inserted emoji to avoid formatting ending and restarting around the emoji

no issue

- apply the current selection's format to the newly inserted emoji to avoid formatting ending and restarting around the emoji
kevinansfield added a commit to kevinansfield/Koenig that referenced this pull request Nov 1, 2023
refs TryGhost#1038

- allows it to be used composed into editors by consumer apps
@kevinansfield kevinansfield merged commit abec4e9 into TryGhost:main Nov 1, 2023
2 checks passed
@kevinansfield kevinansfield deleted the keep-format-on-emoji-insert branch November 1, 2023 17:39
kevinansfield added a commit that referenced this pull request Nov 1, 2023
refs #1038

- allows it to be used composed into editors by consumer apps
kevinansfield added a commit to kevinansfield/Ghost that referenced this pull request Nov 1, 2023
closes TryGhost/Koenig#1038

- updated `<KoenigLexicalEditorInput>` to load `<EmojiPickerPlugin>` and compose it into the editor unless used with `<KoenigLexicalEditorInput @emojipicker={{false}} />`
- bumped Koenig packages so `EmojiPickerPlugin` is available to import from `koenig-lexical`
kevinansfield added a commit to kevinansfield/Ghost that referenced this pull request Nov 1, 2023
closes TryGhost/Koenig#1038

- updated `<KoenigLexicalEditorInput>` to load `<EmojiPickerPlugin>` and compose it into the editor unless used with `<KoenigLexicalEditorInput @emojipicker={{false}} />`
- bumped Koenig packages so `EmojiPickerPlugin` is available to import from `koenig-lexical`
kevinansfield added a commit to TryGhost/Ghost that referenced this pull request Nov 1, 2023
closes TryGhost/Koenig#1038

- updated `<KoenigLexicalEditorInput>` to load `<EmojiPickerPlugin>` and compose it into the editor unless used with `<KoenigLexicalEditorInput @emojipicker={{false}} />`
- bumped Koenig packages so `EmojiPickerPlugin` is available to import from `koenig-lexical`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant