Lowercasing request headers #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs https://github.com/TryGhost/Toolbox/issues/209 refs antongolub/reqresnext#33 - This test should start passing once the upstream dependency (reqresnext) has the referenced issue fixed
naz
force-pushed
the
fix-lowercased-headers
branch
from
726f236
to
1975323
Compare
refs https://github.com/TryGhost/Toolbox/issues/209 refs antongolub/reqresnext#33 - All request headers should be lowercased to match the default behavior in express and node's http module. These patches should be removed once the upstream issue is solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Toolbox/issues/209
refs antongolub/reqresnext#33