Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow inline scripts for post and page content #2

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Conversation

aileen
Copy link
Member

@aileen aileen commented Jan 7, 2019

Allow also inline scripts without src attributes for post and page content.

@aileen aileen requested a review from rishabhgrg January 7, 2019 11:19
gatsby-browser.js Outdated Show resolved Hide resolved
Copy link
Contributor

@rishabhgrg rishabhgrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AileenCGN I did some general testing and overall looks good to me, just left a minor comment for enforcing script type. I don't feel we need to move this to SDK right now :)

@rishabhgrg
Copy link
Contributor

LGTM 🎉

@aileen aileen merged commit a85cd96 into master Jan 8, 2019
@aileen aileen deleted the inline-scripts branch January 8, 2019 08:20
wunderhund added a commit to wunderhund/ggjam-frontend that referenced this pull request Feb 1, 2022
…/websocket-extensions-0.1.4

Bump websocket-extensions from 0.1.3 to 0.1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants