-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added Koenig bookmark card CSS v2 rules #260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TryGhost/Ghost#11024 - 10 bookmark card rules have landed in Ghost as of 2.30.0 release, so they need to be checked for in v2 onwards
daviddarnes
reviewed
Sep 19, 2019
daviddarnes
reviewed
Sep 19, 2019
daviddarnes
reviewed
Sep 19, 2019
daviddarnes
reviewed
Sep 19, 2019
daviddarnes
reviewed
Sep 19, 2019
Co-Authored-By: David Darnes <me@daviddarnes.com>
daviddarnes
reviewed
Sep 19, 2019
Co-Authored-By: David Darnes <me@daviddarnes.com>
daviddarnes
reviewed
Sep 19, 2019
Co-Authored-By: David Darnes <me@daviddarnes.com>
daviddarnes
reviewed
Sep 19, 2019
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Ghost#11024
@kevinansfield would appreciate if you could double-check if all needed styles are correct.
@daviddarnes lets colab on the words used in these rules 💃 will also apply similar wording to other CSS rules.
Things to keep in mind for wording: