Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added Koenig bookmark card CSS v2 rules #260

Merged
merged 9 commits into from
Sep 19, 2019

Conversation

naz
Copy link
Member

@naz naz commented Sep 19, 2019

refs TryGhost/Ghost#11024

  • 10 bookmark card rules have landed in Ghost as of 2.30.0 release, so they need to be checked for in v2 onwards

@kevinansfield would appreciate if you could double-check if all needed styles are correct.

@daviddarnes lets colab on the words used in these rules 💃 will also apply similar wording to other CSS rules.
Things to keep in mind for wording:

  • should not be Ghost version specific (e.g. use Ghsot 2.0)
  • say exactly what will break

TryGhost/Ghost#11024

- 10 bookmark card rules have landed in Ghost as of 2.30.0 release, so they need to be checked for in v2 onwards
lib/specs/v2.js Outdated Show resolved Hide resolved
lib/specs/v2.js Outdated Show resolved Hide resolved
lib/specs/v2.js Outdated Show resolved Hide resolved
lib/specs/v2.js Outdated Show resolved Hide resolved
lib/specs/v2.js Outdated Show resolved Hide resolved
Co-Authored-By: David Darnes <me@daviddarnes.com>
lib/specs/v2.js Outdated Show resolved Hide resolved
Co-Authored-By: David Darnes <me@daviddarnes.com>
lib/specs/v2.js Outdated Show resolved Hide resolved
Co-Authored-By: David Darnes <me@daviddarnes.com>
lib/specs/v2.js Outdated Show resolved Hide resolved
naz and others added 5 commits September 19, 2019 17:01
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
Co-Authored-By: David Darnes <me@daviddarnes.com>
@naz naz merged commit a1d5935 into TryGhost:master Sep 19, 2019
@naz naz deleted the bookmark-card-rules branch September 19, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants