Added new bookmark card #11024
Merged
Added new bookmark card #11024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhgrg
commented
Aug 15, 2019
rishabhgrg
force-pushed
the
bookmark-card
branch
from
96b81d5
to
8570209
Compare
peterzimon
added a commit
to rishabhgrg/Casper
that referenced
this pull request
Aug 26, 2019
refs: TryGhost/Ghost#11024 - added support for Bookmark card for Casper theme
rishabhgrg
force-pushed
the
bookmark-card
branch
from
e395c68
to
fe025c2
Compare
kevinansfield
pushed a commit
to TryGhost/Admin
that referenced
this pull request
Aug 27, 2019
#1293) requires TryGhost/Ghost#11024 With the bookmark card you can present links in a much richer format, similar to Twitter cards. If the URL points to a page with right meta information it can show the page title, excerpt, author, publisher and even a preview image. Bookmark cards can be created in two ways: 1. pasting a link as the first thing in blank paragraph - we'll check to see if we can create an embed, if we can't then we'll create a bookmark card instead 2. manually selecting the bookmark card from the (+) menu or by typing "/bookmark<kbd>Enter</kbd>" or "/bookmark {url}<kbd>Enter</kbd>" for short (you might want to do this if you want the bookmark version instead of a full embed) Pressing <kbd>Ctrl/Cmd+Z</kbd> after pasting will convert the bookmark card back to a link if that's preferred, alternatively a URL can be pasted with <kbd>Ctrl/Cmd+Shift+V</kbd> to avoid any automatic transformation to an embed/bookmark. --- - adds "bookmark" card that functions similarly to the embed card - if the oembed API request returns `type: "bookmark"` then the metadata is used to create a bookmark card
naz
added a commit
to naz/gscan
that referenced
this pull request
Sep 19, 2019
TryGhost/Ghost#11024 - 10 bookmark card rules have landed in Ghost as of 2.30.0 release, so they need to be checked for in v2 onwards
naz
added a commit
to naz/gscan
that referenced
this pull request
Sep 19, 2019
TryGhost/Ghost#11024 - 10 bookmark card rules have landed in Ghost as of 2.30.0 release, so they need to be checked for in v2 onwards
naz
added a commit
to naz/gscan
that referenced
this pull request
Sep 19, 2019
TryGhost/Ghost#11024 - 10 bookmark card rules have landed in Ghost as of 2.30.0 release, so they need to be checked for in v2 onwards
naz
added a commit
to TryGhost/gscan
that referenced
this pull request
Sep 19, 2019
ref TryGhost/Ghost#11024 - 10 bookmark card rules have landed in Ghost as of 2.30.0 release, so they need to be checked for in v2 onwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires TryGhost/Admin#1293
oembedendpoint behaviourmetascraperto populate a metadata object{ "url": "...", "type": "bookmark", "metadata": { "url": "...", "title": "...", "description": "...", "author": "...", "publisher": "...", "thumbnail": "...", "icon": "..." } }bookmarkcard which generates output for the bookmark card: