Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The sqlite3 module works with: Node.js v11.x, v12.x, v13.x and v14.x." but current LTS is 16 #1555

Closed
Pomax opened this issue Apr 4, 2022 · 5 comments
Assignees

Comments

@Pomax
Copy link

Pomax commented Apr 4, 2022

Can the README.md be updated to explain which module should we use for Node v15, v16, v17, and (very soon) v18?

@lehni
Copy link

lehni commented Apr 7, 2022

I was just wondering the same! And yet another unexpected place to meet you again @Pomax ;)

@garyburgmann
Copy link

try: #1556 (comment)

@Pomax
Copy link
Author

Pomax commented Apr 12, 2022

this issue is for getting the actual docs updated, so that no one else needs to hit up /issues for this project and just has the information they need available on the landing page. Because the best workaround right now is to explicitly install the latest node-gyp as devDependency, and then installing, which will then build just fine because it's using the python3 version of node-gyp.

@daniellockyer daniellockyer self-assigned this Apr 12, 2022
@daniellockyer
Copy link
Member

@Pomax Thanks for the note, I'm doing a big overhaul of the repo and docs so I'll be sure to do this too 🙂

daniellockyer added a commit that referenced this issue Apr 13, 2022
refs #1555

- moved some sections around to put the important and notable things first (I think)
- added note about Node-API and prebuilt binaries
- fixed links to point to TryGhost org
- used explicit codeblocks in markdown
@daniellockyer
Copy link
Member

Docs have been updated - let me know if they're still ambiguous 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants