Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syiro.device height and width not triggered on non-MutationObserver-supported browsers #2

Closed
JoshStrobl opened this issue Jul 10, 2015 · 1 comment
Closed

syiro.device height and width not triggered on non-MutationObserver-supported browsers #2

JoshStrobl opened this issue Jul 10, 2015 · 1 comment
Assignees
@JoshStrobl
Labels
bug
Milestone
1.5.0-RC2

Comments

@JoshStrobl
Copy link
Contributor

In 1.5.0-rc1, syiro.device.height and syiro.device.width were created to provide a method to get accurate available screen dimensions.

As it stands now, this is done via a MutationObserver that automatically triggers syiro.device.FetchScreenDetails() when the first Element is added the page (since height isn't able to be accurately calculated until there are Elements on the page) and then automatically removes itself.

Of course, this means that browsers that do not support MutationObserver do not accurately provide dimensions. This obviously needs to be resolved (most likely with an automatically clearing WindowTimer and using window.setTimeout()).
@JoshStrobl JoshStrobl added the bug label Jul 10, 2015
@JoshStrobl JoshStrobl self-assigned this Jul 10, 2015
@JoshStrobl JoshStrobl added this to the 1.5.0-RC2 milestone Jul 10, 2015
JoshStrobl added a commit that referenced this issue Jul 24, 2015
@JoshStrobl
Refactor MutationObserver support checking, moving it to syiro.device…
f94bab8 
….Detect() and using syiro.device.SupportsMutationObservever. Implement though untested fix for resolving issue #2, syiro.device heigh/width not updating on non-MutationObserver-supported browsers.
@JoshStrobl
Copy link
Contributor Author

Verified bug resolves screen height / width detection issues. Closing bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshStrobl JoshStrobl

Labels
bug
Projects
None yet
Milestone
1.5.0-RC2
Development

No branches or pull requests
1 participant
@JoshStrobl