Add playback speed function and UI #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackSettingDialog menu.
…eeds to be using immersive stytle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I utilize ExoPlayer's built in playback speed functionality and open up a button in player activity to set it. The UI is a simplified version of YouTube's.
UI walk thought:
At Top right corner you will see a new setting button with the typical 3-vertical-dots image. Tab and it will open the first AlertDialog, the Setting Menu. Then you will see Playback Speed as the only option, notices the current speed text is set programmatically. Tab it and it will bring you to the second AlertDialog, the Speed Menu, where you choose the playback speed.
Following architecture:
I followed the DI pattern and add a PlaybackSettingMenu class to handle all the nested menus. I also modularized the Option in Setting Menu, so adding and removing items will be easier in the future.
Things to consider:
This is more like two features(Setting Menu & Speed Menu) in a PR. I should have asked you guys about the UI first. I also notices the visibility flag for the subtitle button. You may not want the Setting Menu at all, or want it as an option. Let me know.
As my first PR for this repo, hope I'm not doing too badly and is following practices correctly. You guys have good days ahead!