Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add playback speed function and UI #97

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Add playback speed function and UI #97

wants to merge 30 commits into from

Commits on May 22, 2019

  1. Add a setting ImageButton. Add a onClick callback method. Add a Playb… 

    …ackSettingDialog menu.
    @dahis39
    dahis39 committed May 22, 2019
    Configuration menu
    Copy the full SHA
    46a59e9 View commit details
    Browse the repository at this point in the history

  2. Move to a better location

    @dahis39
    dahis39 committed May 22, 2019
    Configuration menu
    Copy the full SHA
    3c9c382 View commit details
    Browse the repository at this point in the history

  3. Add playback speed enum and strings

    @dahis39
    dahis39 committed May 22, 2019
    Configuration menu
    Copy the full SHA
    e82468c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. Rename method. Bring the method call all the way up into activity layer.

    @dahis39
    dahis39 committed May 23, 2019
    Configuration menu
    Copy the full SHA
    bbed653 View commit details
    Browse the repository at this point in the history

  2. Get all the wiring going correctly.

    @dahis39
    dahis39 committed May 23, 2019
    Configuration menu
    Copy the full SHA
    8e83027 View commit details
    Browse the repository at this point in the history

  3. Get nested alert dialop going

    @dahis39
    dahis39 committed May 23, 2019
    Configuration menu
    Copy the full SHA
    e50ebf5 View commit details
    Browse the repository at this point in the history

  4. Clean ups

    @dahis39
    dahis39 committed May 23, 2019
    Configuration menu
    Copy the full SHA
    db6eb61 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. Add a dismiss method

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    dd5f566 View commit details
    Browse the repository at this point in the history

  2. Get playback menu title to includes current speed.

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    7f2d11c View commit details
    Browse the repository at this point in the history

  3. Make method more general. Add TODO

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    9db6ee3 View commit details
    Browse the repository at this point in the history

  4. Code clean up and small refacotring

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    fc71163 View commit details
    Browse the repository at this point in the history

  5. Fix margin setting

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    faa7c07 View commit details
    Browse the repository at this point in the history

  6. Use proper images

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    5c77a00 View commit details
    Browse the repository at this point in the history

  7. Better naming

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    658343b View commit details
    Browse the repository at this point in the history

  8. Remove my no longer needed TODO and commented out code

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    990719e View commit details
    Browse the repository at this point in the history

  9. Add remove spacing

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    59f6995 View commit details
    Browse the repository at this point in the history

  10. Unify naming convention

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    4678b09 View commit details
    Browse the repository at this point in the history

  11. Remove unused import

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    f93b1d9 View commit details
    Browse the repository at this point in the history

  12. Use a list that shows current selected item

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    0b79b7a View commit details
    Browse the repository at this point in the history

  13. Not all titles will be dynamic

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    18b74cc View commit details
    Browse the repository at this point in the history

  14. Write title strings in xml. Use the shorthanded getString method.

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    1aea9e9 View commit details
    Browse the repository at this point in the history

  15. Move buildOption method after inject context

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    2983ff9 View commit details
    Browse the repository at this point in the history

  16. Move buildOptions all the way out

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    8c4176e View commit details
    Browse the repository at this point in the history

  17. Avoid duplicated initialization.

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    e6f367e View commit details
    Browse the repository at this point in the history

  18. Pass in activity instead of context. Make dialog not trigger system n… 

    …avigation bar.
    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    f2852a4 View commit details
    Browse the repository at this point in the history

  19. Keep the navigation bar not appearing when show a alert dialog.

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    eed9635 View commit details
    Browse the repository at this point in the history

  20. Use newer style for list toArray.

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    db33c62 View commit details
    Browse the repository at this point in the history

  21. Use single method.

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    6821d97 View commit details
    Browse the repository at this point in the history

  22. Better comment

    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    3aeee98 View commit details
    Browse the repository at this point in the history

  23. Specify the activity requirement for SettingMenu since the activity n… 

    …eeds to be using immersive stytle.
    @dahis39
    dahis39 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    c5b0571 View commit details
    Browse the repository at this point in the history