Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #100

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Improve test coverage #100

merged 1 commit into from
Aug 22, 2020

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Apr 23, 2020

This PR adds a few more tests to improve the test coverage of the plugin to 100%

@brettz9
Copy link
Contributor Author

brettz9 commented May 12, 2020

I've rebased and also bumped the version to drop Node 6 (the latest nyc I added requires it, it also would allow using up-to-date versions of Mocha and import-from, and even Node 8 has been end-of-lifed and being dropped by many projects).

@brettz9

This comment has been minimized.

@brettz9
Copy link
Contributor Author

brettz9 commented Jun 24, 2020

Thanks for the merge! I've rebased this one now as well...

@brettz9
Copy link
Contributor Author

brettz9 commented Jun 24, 2020

Was breakage with Mocha 8 and ESLint 3, so also dropped <=3 from peerDeps and Travis.

@brettz9
Copy link
Contributor Author

brettz9 commented Jun 24, 2020

And with Mocha 8 requiring Node 10 and Node 8 end-of-lifed, I added another commit to drop Node 8 from engines. If you still want the support, travis.yml should test Node 8 I think but it would also need to downgrade Mocha as well as ESLint.

@Turbo87
Copy link
Owner

Turbo87 commented Jul 8, 2020

@brettz9 can you split these changes into multiple PRs so that they can be discussed individually? 🙏

@brettz9 brettz9 force-pushed the coverage branch 2 times, most recently from 23109fb to da21335 Compare July 8, 2020 15:02
@brettz9
Copy link
Contributor Author

brettz9 commented Jul 8, 2020

Sure, I'm happy to split them up, and I started #114 which presents one item by itself.


FWIW though, if you are interested to know my process on why I connected all of these...

I added nyc so one can get reports that all lines of your code base are covered by the tests. I set thresholds at 100% so any regressions of coverage would break Travis. And to avoid breaking Travis with such coverage now checked, I added tests necessary to bring the project to 100% coverage.

Since the latest nyc requires Node 8+, I updated travis.yml to drop Node 8 and check the current supported Node versions (12 and 14). And if you are ok upgrading, I figured we might as well also check ESLint 7 and Mocha 8 which depend on higher Node versions, though with Mocha 8, we have to drop ESLint 3 (as it fails with it) and bump Node further to Node 10+.

@brettz9
Copy link
Contributor Author

brettz9 commented Aug 22, 2020

Rebased also with no breaking changes.

@Turbo87 Turbo87 changed the title Coverage Improve test coverage Aug 22, 2020
@Turbo87 Turbo87 merged commit 459dab8 into Turbo87:master Aug 22, 2020
@brettz9 brettz9 deleted the coverage branch August 22, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants