50x performance increase for invariant.getCoords() #1199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
50x performance increase to
invariant.getCoords()
Ref: #914 (comment)
Using the same performance approach as
invariant.getCoord
(PR #1197).containNumbers()
validation (this method can be executed separately)Benchmark Results
Benchmark Results (Before)
CC: @strech345 @rowanwins @stebogit